Item2321: PATCH /attachment works - both entire topic's FILEATTACHMEN…

…T array - really is a PUT /attachment, or a PATCH on /topic :)

git-svn-id: http://svn.foswiki.org/trunk@10192 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

core/lib/Foswiki/Func.pm

@@ -1627,6 +1627,9 @@ Test if attachment exists
    * =$attachment= - attachment name, e.g.=logo.gif=
 $web and $topic are parsed as described in the documentation for =normalizeWebTopicName=.
 
+The attachment must exist in the store (it is not sufficient for it to be referenced
+in the object only)
+
 =cut
 
 sub attachmentExists {

core/lib/Foswiki/Meta.pm

@@ -459,6 +459,9 @@ sub unload {
         delete $this->{$type};
     }
     undef $this->{_indices};
+
+    #SMELL: Sven noticed diring development that something is adding a $this->{store} to a meta obj - havn't found it yet
+    #ASSERT(not defined($this->{store})) if DEBUG;
 }
 
 =begin TML

core/lib/Foswiki/Serialise.pm

@@ -81,6 +81,7 @@ sub convertMeta {
     foreach my $key ( keys(%$savedMeta) ) {
         next if ( $key eq '_session' );
         next if ( $key eq '_indices' );
+        next if ( $key eq 'store' );
 
         #TODO: next if ( $key is one of the array types... and has no elements..