Item13169: Fix PerlDependencyReport

Macro called with wrong quotes in parameter Extensions handling was also processing the core dependencies, causing double reporting.
foswiki · Dec 21, 2014 · 36ddea6 · 36ddea6
1 parent 0f78371
commit 36ddea6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/data/System/PerlDependencyReport.txt b/core/data/System/PerlDependencyReport.txt
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="ProjectContributor" comment="" date="1411624271" format="1.1" reprev="1" version="1"}%
+%META:TOPICINFO{author="ProjectContributor" date="1419141850" format="1.1" version="1"}%
 %META:TOPICPARENT{name="InstallationGuide"}%
 
 ---+!! Perl dependencies for Foswiki and Extensions
@@ -22,6 +22,6 @@ requiring the highest minimum version is underlined.
 
 ---++ Foswiki extension dependencies
 
-%PERLDEPENDENCYREPORT{'extensions'}%
+%PERLDEPENDENCYREPORT{"extensions"}%
 </noautolink>
 
diff --git a/core/lib/Foswiki/Macros/PERLDEPENDENCYREPORT.pm b/core/lib/Foswiki/Macros/PERLDEPENDENCYREPORT.pm
@@ -80,7 +80,8 @@ sub _analyzeExtensions {
       File::Spec->catfile( @dir, 'Foswiki', 'Contrib', 'core', 'DEPENDENCIES' );
 
     my %seen;
-    my $perlModules = _loadDEPENDENCIES( $from, 'core', \%seen );
+    my @mods;
+    my $perlModules = \@mods;
 
     foreach my $info ( values %seen ) {
         if ( $info->{usage} ) {