Item12027: Apply Plainfile fix to Compatibility

git-svn-id: http://svn.foswiki.org/trunk@17218 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
foswiki · Jan 7, 2014 · 3e50a35 · 3e50a35
1 parent e01e4c4
commit 3e50a35
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/lib/Foswiki/Logger/Compatibility.pm b/core/lib/Foswiki/Logger/Compatibility.pm
@@ -115,10 +115,12 @@ sub log {
     my $file;
     my $mode = '>>';
 
-    # Item10764, SMELL UNICODE: actually, perhaps we should open the stream this
-    # way for any encoding, not just utf8. Babar says: check what Catalyst does.
+  # Item10764, SMELL UNICODE: actually, perhaps we should open the stream this
+  # way for any encoding, not just utf8. Babar says: check what Catalyst does.
+  # Item12027: this only makes sense for Unicode strings, not UTF-8 byte strings
     if (   $Foswiki::cfg{Site}{CharSet}
-        && $Foswiki::cfg{Site}{CharSet} =~ /^utf-?8$/ )
+        && $Foswiki::cfg{Site}{CharSet} =~ /^utf-?8$/
+        && utf8::is_utf8($message) )
     {
         $mode .= ":encoding($Foswiki::cfg{Site}{CharSet})";
     }