Item12888: Fix ConfigureSave tests

Add a field to test undefok. Don't depend upon TempfileDir.
foswiki · Jan 16, 2015 · 43ffd46 · 43ffd46
1 parent 4ffeb2f
commit 43ffd46
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/UnitTestContrib/lib/Foswiki/Contrib/UnitTestContrib/Config.spec b/UnitTestContrib/lib/Foswiki/Contrib/UnitTestContrib/Config.spec
@@ -86,6 +86,9 @@ $Foswiki::cfg{UnitTestContrib}{Configure}{EXPERT} = 'EXPERT';
 # **PATH CHECK='undefok'**
 # Default: empty
 # $Foswiki::cfg{UnitTestContrib}{Configure}{empty} = 'empty';
+# **STRING CHECK='undefok'**
+# Default: value
+$Foswiki::cfg{UnitTestContrib}{Configure}{undefok} = 'value';
 # **STRING CHECK="undefok"**
 # Should contain other items
 $Foswiki::cfg{UnitTestContrib}{Configure}{DEP_STRING} = 'xxx$Foswiki::cfg{UnitTestContrib}{Configure}{H}xxx';

diff --git a/UnitTestContrib/test/unit/ConfigureSaveTests.pm b/UnitTestContrib/test/unit/ConfigureSaveTests.pm
@@ -17,6 +17,7 @@ use Foswiki::Configure::Reporter;
 
 # TODO: this needs to test that backups are correctly made
 sub test_changecfg {
+
     my $this   = shift;
     my $params = {
         set => {
@@ -37,7 +38,7 @@ sub test_changecfg {
             '{UnitTestContrib}{Configure}{REGEX}' => '(black|white)+',
 
             # Undeffable
-            '{TempfileDir}' => '',
+            '{UnitTestContrib}{Configure}{undefok}' => undef,
         }
     };
 
@@ -83,7 +84,12 @@ sub test_changecfg {
             level => 'notes',
             text =>
 q<| {UnitTestContrib}{Configure}{REGEX} | (^regex$) | '(black&#124;white)+' |>,
-        }
+        },
+        {
+            level => 'notes',
+            text =>
+              '| {UnitTestContrib}{Configure}{undefok} | \'value\' | undef |',
+        },
     ];
     my $ms = $reporter->messages();
 

diff --git a/UnitTestContrib/test/unit/ConfigureTestCase.pm b/UnitTestContrib/test/unit/ConfigureTestCase.pm
@@ -55,6 +55,7 @@ $Foswiki::cfg{UnitTestContrib}{Configure}{URL} = 'http://google.com';
 $Foswiki::cfg{UnitTestContrib}{Configure}{H} = 'hidden';
 $Foswiki::cfg{UnitTestContrib}{Configure}{EXPERT} = 'iot';
 $Foswiki::cfg{UnitTestContrib}{Configure}{empty} = 'full';
+$Foswiki::cfg{UnitTestContrib}{Configure}{undefok} = 'value';
 $Foswiki::cfg{UnitTestContrib}{Configure}{DEP_STRING} = 'xxx$Foswiki::cfg{UnitTestContrib}{Configure}{H}xxx';
 $Foswiki::cfg{UnitTestContrib}{Configure}{DEP_PERL} = {
     'string' => 'real$Foswiki::cfg{UnitTestContrib}{Configure}{URL}/man'