Item10344: looks like the problem was that Store::getRevision was ret…

…urning (undef, 1) if the topic didn't exist - which is slightly mad

git-svn-id: http://svn.foswiki.org/trunk@10733 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

core/lib/Foswiki/Meta.pm

@@ -445,12 +445,14 @@ sub load {
         return $m if (defined($m));
     }
 
+    ASSERT( not ($this->{_latestIsLoaded}) ) if DEBUG;
+
     my $loadedRev = $this->loadVersion($rev);
     #insane as this seems, load can fail to load, but will give you some kind of valid seeming Meta obecjt.
     if (not defined($loadedRev)) {
         ASSERT( not defined( $this->{_loadedRev} ) ) if DEBUG;
-        #_latestIsloaded is mostly undef when the topic is not ondisk, except Fn_SEARCH::verify_refQuery_ForkingSearch and friends
-        #ASSERT( not defined($this->{_latestIsLoaded}) ) if DEBUG;
+        #_latestIsloaded is mostly undef / 0 when the topic is not ondisk, except Fn_SEARCH::verify_refQuery_ForkingSearch and friends
+        ASSERT( not ($this->{_latestIsLoaded}) ) if DEBUG;
     } else {
         ASSERT( defined( $this->{_loadedRev} ) and ($this->{_loadedRev} >0)) if DEBUG;
         ASSERT( defined($this->{_latestIsLoaded}) ) if DEBUG;
@@ -1017,6 +1019,9 @@ sub loadVersion {
         $this->{_text} = '' unless defined $this->{_text};
 
         $this->addDependency();
+    } else {
+        #we didn't load, so how could it be latest?
+        ASSERT(not $this->{_latestIsLoaded}) if DEBUG;
     }
 
     return $this->{_loadedRev};

core/lib/Foswiki/Store/VC/Handler.pm

@@ -433,7 +433,7 @@ sub getRevision {
     if ( -e $this->{file} ) {
         return (readFile( $this, $this->{file} ), 1 );
     }
-    return (undef, 1);
+    return (undef, 0);
 }
 
 =begin TML

core/lib/Foswiki/Store/VC/Store.pm

@@ -84,6 +84,7 @@ sub readTopic {
     if (defined($gotRev) and ($gotRev > 0)) {
         return ($gotRev, $isLatest) 
     }
+    ASSERT(not $isLatest) if DEBUG;
 
     my $handler = $this->getHandler($topicObject);
     $isLatest = 0;
@@ -97,6 +98,7 @@ sub readTopic {
 
     (my $text, $isLatest) = $handler->getRevision($version);
     unless (defined $text) {
+        ASSERT(not $isLatest) if DEBUG;
         return (undef, $isLatest) 
     }