Skip to content

Commit

Permalink
Item9057: simplify ASSERT so debugging is more obvious - it never hel…
Browse files Browse the repository at this point in the history
…ps the reader to have one assert testing more than one condition. swap rev specification parameters sent to summarise - the first is the 'old' rev, the second is the 'new' or 'current'

git-svn-id: http://svn.foswiki.org/trunk@7531 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
SvenDowideit authored and SvenDowideit committed May 25, 2010
1 parent 9d5a903 commit 5b23b0a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion core/lib/Foswiki/Meta.pm
Expand Up @@ -2860,7 +2860,8 @@ sub summariseChanges {

$orev = $nrev - 1 unless defined($orev);

ASSERT( $orev >= 0 && $nrev >= $orev ) if DEBUG;
ASSERT( $orev >= 0 ) if DEBUG;
ASSERT( $nrev >= $orev ) if DEBUG;

$this->reload($nrev);

Expand Down
2 changes: 1 addition & 1 deletion core/lib/Foswiki/UI/Changes.pm
Expand Up @@ -65,7 +65,7 @@ sub changes {
try {
my $topicObject =
Foswiki::Meta->new( $session, $webObject->web, $change->{topic} );
my $summary = $topicObject->summariseChanges( $change->{revision} );
my $summary = $topicObject->summariseChanges( undef, $change->{revision} );
my $thisChange = $eachChange;
$thisChange =~ s/%TOPICNAME%/$change->{topic}/go;
my $wikiuser =
Expand Down

0 comments on commit 5b23b0a

Please sign in to comment.