Skip to content

Commit

Permalink
Item13897: Removed buggy ASSERT
Browse files Browse the repository at this point in the history
Never failed because of a mistype but breaks valid test when mistype gets
corrected.
  • Loading branch information
vrurg committed Jan 14, 2016
1 parent e094e02 commit 6166c33
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions core/lib/Foswiki/Address.pm
Expand Up @@ -1609,10 +1609,12 @@ sub isValid {
ASSERT( ref( $this->tompath ) eq 'ARRAY'
and scalar( @{ $this->tompath } ) )
if DEBUG;
ASSERT(
not( $this->tompath->[0]
and $this->tompath->[0] eq 'attachment' )
) if DEBUG;

# vrurg This ASSERT had a mistype in non-Moo version which was making it harmless. In fact, it seems to be incorrect.
#ASSERT(
# not( $this->tompath->[0]
# and $this->tompath->[0] eq 'attachment' )
#) if DEBUG;
ASSERT( $pathtypes{ $this->tompath->[0] } ) if DEBUG;
$this->_type( $pathtypes{ $this->tompath->[0] }
->{ scalar( @{ $this->tompath } ) } );
Expand Down

0 comments on commit 6166c33

Please sign in to comment.