Item12346: fixed jittering cursor and scrollbars in IE8

git-svn-id: http://svn.foswiki.org/trunk@16379 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
foswiki · Jan 15, 2013 · 636813f · 636813f
1 parent f3f4d5f
commit 636813f
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 14 deletions.
diff --git a/NatEditPlugin/data/System/NatEditPlugin.txt b/NatEditPlugin/data/System/NatEditPlugin.txt
@@ -55,11 +55,12 @@ is sufficient.
 %$INSTALL_INSTRUCTIONS%
 
 |  Author: | Michael Daum |
-|  Copyright &copy;: | 2007-2012 Michael Daum http://michaeldaumconsulting.com |
+|  Copyright &copy;: | 2007-2013 Michael Daum http://michaeldaumconsulting.com |
 |  License: | GPL ([[http://www.gnu.org/copyleft/gpl.html][GNU General Public License]]) |
 |  Release: | %$RELEASE% |
 |  Version: | %$VERSION% |
 |  Change History: | |
+|  15 Jan 2013 | added work-around for an IE8 bug in textareas |
 |  21 Dec 2012 | added in-edit upload support using Foswiki:Extensions/TopicInteractionPlugin |
 |  29 Oct 2012 | removed local button styles to allow theming via jquery-ui; use of NATEDIT_THEME is deprecated from now on|
 |  22 Oct 2012 | implemented improved list editing; rewrite of modal dialogs to use jquery-ui-dialog instead of the old simplemodal library |

diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2007-2012 Michael Daum http://michaeldaumconsulting.com
+# Copyright (C) 2007-2013 Michael Daum http://michaeldaumconsulting.com
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -20,8 +20,8 @@ use Foswiki::Plugins    ();
 use Foswiki::Validation ();
 
 # Simple decimal version, use parse method, no leading "v"
-use version; our $VERSION = version->parse("7.00");
-our $RELEASE           = '7.00';
+use version; our $VERSION = version->parse("7.01");
+our $RELEASE           = '7.01';
 our $NO_PREFS_IN_TOPIC = 1;
 our $SHORTDESCRIPTION  = 'A Wikiwyg Editor';
 our $baseWeb;

diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/FormButton.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/FormButton.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2007-2012 Michael Daum http://michaeldaumconsulting.com
+# Copyright (C) 2007-2013 Michael Daum http://michaeldaumconsulting.com
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License

diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/FormList.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/FormList.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2007-2012 Michael Daum http://michaeldaumconsulting.com
+# Copyright (C) 2007-2013 Michael Daum http://michaeldaumconsulting.com
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License

diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/NATEDIT.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/NATEDIT.pm
@@ -1,6 +1,6 @@
 # Plugin for Foswiki - The Free and Open Source Wiki, http://foswiki.org/
 #
-# Copyright (C) 2006-2012 Michael Daum, http://michaeldaumconsulting.com
+# Copyright (C) 2006-2013 Michael Daum, http://michaeldaumconsulting.com
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -42,7 +42,7 @@ sub new {
     my $this = bless(
         $class->SUPER::new(
             name          => 'NatEdit',
-            version       => '3.01',
+            version       => '3.02',
             author        => 'Michael Daum',
             homepage      => 'http://foswiki.org/Extensions/NatEditPlugin',
             puburl        => '%PUBURLPATH%/%SYSTEMWEB%/NatEditPlugin',

diff --git a/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/RestSave.pm b/NatEditPlugin/lib/Foswiki/Plugins/NatEditPlugin/RestSave.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2012 Michael Daum http://michaeldaumconsulting.com
+# Copyright (C) 2013 Michael Daum http://michaeldaumconsulting.com
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License

diff --git a/NatEditPlugin/pub/System/NatEditPlugin/default/styles.uncompressed.css b/NatEditPlugin/pub/System/NatEditPlugin/default/styles.uncompressed.css
@@ -1,5 +1,5 @@
 /* default theme */
-.natEditToolBar { padding:0px; margin:0px 0px 3px 0px; float:left;}
+.natEditToolBar { padding:0px; margin:0px 0px 3px 0px;}
 .natEditToolBar a:hover,
 .natEditToolBar a {
   width:25px; 

diff --git a/NatEditPlugin/pub/System/NatEditPlugin/jquery.natedit.uncompressed.js b/NatEditPlugin/pub/System/NatEditPlugin/jquery.natedit.uncompressed.js
@@ -1,7 +1,7 @@
 /*
  * jQuery NatEdit plugin 
  *
- * Copyright (c) 2008-2012 Michael Daum http://michaeldaumconsulting.com
+ * Copyright (c) 2008-2013 Michael Daum http://michaeldaumconsulting.com
  *
  * Dual licensed under the MIT and GPL licenses:
  *   http://www.opensource.org/licenses/mit-license.php
@@ -598,7 +598,7 @@ $.NatEditor.prototype.setSelectionRange = function(start, end) {
 
   //$.log("setSelectionRange("+self.txtarea+", "+start+", "+end+")");
   $(self.txtarea).focus();
-  if (self.txtarea.createTextRange && !$.browser.opera) {
+  if (typeof(self.txtarea.createTextRange) !== 'undefined' && !$.browser.opera) {
     lineFeeds = self.txtarea.value.substring(0, start).replace(/[^\r]/g, "").length;
     range = self.txtarea.createTextRange();
     range.collapse(true);

diff --git a/NatEditPlugin/pub/System/NatEditPlugin/styles.uncompressed.css b/NatEditPlugin/pub/System/NatEditPlugin/styles.uncompressed.css
@@ -11,7 +11,11 @@
 }
 .natEdit textarea,
 .natEditTextArea {
-  width:100% !important;
+  /* working around IE8 textarea bugs: make it think it gets a fixed width but then junk in min and max width 100% */
+  width:500px !important; 
+  min-width:100%;
+  max-width:100%;
+
   font-family:"Bitstream Vera Sans Mono", "Andale Mono", monospace;
   font-size:12px;
   line-height:1.5em;

diff --git a/NatEditPlugin/templates/edit.natedit.tmpl b/NatEditPlugin/templates/edit.natedit.tmpl
@@ -48,7 +48,7 @@
 <input type="hidden" name="templatetopic" value="%TEMPLATETOPIC%" />
 <input type="hidden" name="template" value="%URLPARAM{"template"}%" />%TMPL:END%
 
-%TMPL:DEF{"textarea"}%<textarea id="topic" class="foswikiTextarea foswikiWysiwygEdit natEditTextArea natedit {autoMaxExpand:true, minHeight:215 %TMPL:P{"natedit::options"}%}" wrap="virtual" name="text" rows="22" cols="70">%TEXT%</textarea>%TMPL:END%
+%TMPL:DEF{"textarea"}%<textarea id="topic" class="foswikiTextarea foswikiWysiwygEdit natEditTextArea natedit {autoMaxExpand:true, minHeight:215 %TMPL:P{"natedit::options"}%}" name="text" rows="22" cols="70">%TEXT%</textarea>%TMPL:END%
 %TMPL:DEF{"messages"}%<div id="natEditMessageContainer"></div>%TMPL:END%
 
 %TMPL:DEF{"formend"}%<input type="hidden" name="forcenewrevision" value="%URLPARAM{"forcenewrevision"}%" />