Skip to content

Commit

Permalink
Item660: Clarify disposition of dependencies, and report CPAN depende…
Browse files Browse the repository at this point in the history
…nces that may require

manual intervention.


git-svn-id: http://svn.foswiki.org/trunk@7134 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
GeorgeClark authored and GeorgeClark committed Apr 9, 2010
1 parent b7417a8 commit 777717f
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion core/lib/Foswiki/Configure/UIs/EXTEND.pm
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ sub _install {

my $pkg = new Foswiki::Configure::Package ($this->{root}, $extension, $session);
$pkg->repository($repository);
my ($rslt, $plugins) = $pkg->fullInstall();
my ($rslt, $plugins, $depCPAN) = $pkg->fullInstall();

_printFeedback($rslt);

Expand All @@ -96,6 +96,25 @@ sub _install {
else {
# OK
$feedback .= $this->NOTE_OK( 'Installation finished' );
$feedback .= $this->NOTE(<<HERE);
Before proceeding, review the dependency reports of each installed extension and
resolve any dependencies as required. <ul><li>External dependencies are never automatically
resolved by Foswiki. <li>Dependencies noted as "Optional" will not be automatically
resolved, and <li>CPAN dependencies are not resolved by the web installer.
HERE
}

if ( scalar @$depCPAN ) {
$feedback .= $this->NOTE(<<HERE);
Warning: CPAN dependencies were detected, but will not be automatically installed
by the Web installer. The following dependencies should be manually resolved as
required.
HERE
$feedback .= "<pre>";
foreach my $dep (@$depCPAN) {
$feedback .= "$dep->{module}\n" if $dep;
}
$feedback .= "</pre>";
}

if ( scalar @$plugins ) {
Expand Down

0 comments on commit 777717f

Please sign in to comment.