Skip to content

Commit

Permalink
Item12952: Partial fix for email wizard.
Browse files Browse the repository at this point in the history
missing elsif caused fallthru to failure even when configuration worked.

Also remove the PREFORMAT: tag so that the debug log is readable.

There are still some issues.   It doesn't actually apply any
configuration changes.  Testing with gmail.  587 Submission with STARTTLS works
fine,  but configuration is left at hostname, no port,  and SMTP not
STARTTLS.

Also the code that masked passwords to avoid shoulder surfing while
configuration is exposed has been lost,  so passwords are stored in
plain text.    This is lame,  we probably ought to store using some
basic encryption.  But the masking was better than nothing.
  • Loading branch information
gac410 committed Aug 30, 2014
1 parent 6de4896 commit 793f8fa
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/lib/Foswiki/Configure/Wizards/AutoConfigureEmail.pm
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ sub _autoconfigPerl {
close $fd2;
open( STDERR, '>&', $stderr ) or die "stderr:$!\n";
close $stderr;
$reporter->NOTE("PREFORMAT:$tlog");
$reporter->NOTE($tlog);

unless (@use) {
_diagnoseFailure( $noconnect, $allconnect, $reporter );
Expand All @@ -606,7 +606,7 @@ sub _autoconfigPerl {
if ( $use[2] == 1 || $use[2] == 4 ) { # OK, Not required
$reporter->NOTE( $use[3], ACCEPTMSG );
}
if ( $use[2] == 2 ) { # Bad credentials
elsif ( $use[2] == 2 ) { # Bad credentials
# Authentication failed, perl is OK, don't try program.
$reporter->ERROR( $use[3] );
}
Expand Down

0 comments on commit 793f8fa

Please sign in to comment.