Item15151: add warnings and strictness

- added no critic where appropriate
- removed PiwikPlugin from core
- switching output from :utf8 to :encoding(UTF-8) as suggested by PBP
- fixed mixed comparators: numerics being compared using string comparator and vice versa
- fixed loop iterators not being scoped lexically
- replaced/removed , as a command separator
- fixed mixed precedence comparators (or vs || etc)
- simplified some eval "use $impl" patterns

Item15150: support hierarchical template webs in the regexes

note, creating a web from a hierarchical template web isn't supported yet (-> 2.2.0)

BuildContrib/lib/Foswiki/Contrib/BuildContrib.pm

@@ -1,5 +1,6 @@
 package Foswiki::Contrib::BuildContrib;
 use strict;
+use warnings;
 
 our $VERSION = '2.10';
 our $RELEASE = '27 Apr 2022';

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/POD.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 # Build POD documentation. This target defines =%$POD%= - it
 # does not generate any output. The target will be invoked

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/compress.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 my %minifiers;    # functions used to minify
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/gitignore.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 my $collector;
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/handsoff_install.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/history.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/install.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/installer.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/manifest.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 my $collector;
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/release.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/stage.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 our @stageFilters;
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/test.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/tidy.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 my @tidyFilters = ( { RE => qr/\.pl$/ }, { RE => qr/\.pm$/ }, );
 my $collector;

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/tracked.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 our $DEFAULTCUSTOMERDB = "$ENV{HOME}/customerDB";
 

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/twiki.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 our @twikiFilters = (
     { RE => qr/\.pm$/,          filter => '_twikify_perl' },

BuildContrib/lib/Foswiki/Contrib/BuildContrib/Targets/uninstall.pm

@@ -16,6 +16,7 @@
 package Foswiki::Contrib::Build;
 
 use strict;
+use warnings;
 
 =begin TML
 

BuildContrib/lib/Perl/Tidy.pm

@@ -57,6 +57,7 @@ use 5.004;    # need IO::File from 5.004 or later
 BEGIN { $^W = 1; }    # turn on warnings
 
 use strict;
+use warnings;
 use Exporter;
 use Carp;
 $|++;

CommentPlugin/lib/Foswiki/Plugins/CommentPlugin/JQuery.pm

@@ -4,6 +4,7 @@
 
 package Foswiki::Plugins::CommentPlugin::JQuery;
 use strict;
+use warnings;
 
 use Foswiki::Plugins::JQueryPlugin::Plugin ();
 our @ISA = qw( Foswiki::Plugins::JQueryPlugin::Plugin );

CompareRevisionsAddOn/lib/Foswiki/Contrib/CompareRevisionsAddOn.pm

@@ -1,5 +1,6 @@
 package Foswiki::Contrib::CompareRevisionsAddOn;
 use strict;
+use warnings;
 
 # Also update CompareRevisionsAddOnPlugin
 our $VERSION = '1.115';

ConfigurePlugin/lib/Foswiki/Plugins/ConfigurePlugin/JQuery.pm

@@ -4,6 +4,7 @@
 
 package Foswiki::Plugins::ConfigurePlugin::JQuery;
 use strict;
+use warnings;
 
 use Foswiki::Plugins::JQueryPlugin::Plugin ();
 our @ISA = qw( Foswiki::Plugins::JQueryPlugin::Plugin );

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin;
 
 use strict;
+use warnings;
 use Foswiki::Request                      ();
 use Foswiki::Render                       ();
 use Foswiki::Plugins::EditRowPlugin::View ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor.pm

@@ -4,6 +4,7 @@ package Foswiki::Plugins::EditRowPlugin::Editor;
 # Base class of editor plugins
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Func ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/checkbox.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::checkbox;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/date.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::date;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/editbutton.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::editbutton;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor::label ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/label.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::label;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/radio.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::radio;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/row.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::row;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor::label ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/select.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::select;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/text.pm

@@ -9,6 +9,7 @@ package Foswiki::Plugins::EditRowPlugin::Editor::text;
 # Note that textarea subclasses this class.
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Editor/textarea.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Editor::textarea;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Plugins::EditRowPlugin::Editor::text ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/JQuery.pm

@@ -15,6 +15,7 @@
 
 package Foswiki::Plugins::EditRowPlugin::JQuery;
 use strict;
+use warnings;
 
 use Assert;
 

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Table.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::Table;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Tables::Table ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableCell.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::TableCell;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Func                           ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableParser.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::TableParser;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Attrs          ();

EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/TableRow.pm

@@ -2,6 +2,7 @@
 package Foswiki::Plugins::EditRowPlugin::TableRow;
 
 use strict;
+use warnings;
 use Assert;
 
 use Foswiki::Func ();

InterwikiPlugin/test/unit/InterwikiPlugin/InterwikiPluginSuite.pm

@@ -1,6 +1,7 @@
 package InterwikiPluginSuite;
 
 use strict;
+use warnings;
 
 use Unit::TestSuite;
 our @ISA = 'Unit::TestSuite';

InterwikiPlugin/test/unit/InterwikiPlugin/InterwikiPluginTests.pm

@@ -1,6 +1,7 @@
 package InterwikiPluginTests;
 
 use strict;
+use warnings;
 
 use FoswikiFnTestCase;
 our @ISA = qw( FoswikiFnTestCase );

JSCalendarContrib/test/unit/JSCalendarContribTests.pm

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 
 package JSCalendarContribTests;
 

ModPerlEngineContrib/lib/Foswiki/Contrib/ModPerlEngineContrib.pm

@@ -20,6 +20,7 @@
 package Foswiki::Contrib::ModPerlEngineContrib;
 
 use strict;
+use warnings;
 
 use vars qw( $VERSION $RELEASE $SHORTDESCRIPTION );
 

ModPerlEngineContrib/lib/Foswiki/Engine/Apache.pm

@@ -36,6 +36,7 @@ Refer to Foswiki::Engine documentation for explanation about methos below.
 package Foswiki::Engine::Apache;
 
 use strict;
+use warnings;
 
 use Foswiki::Engine;
 our @ISA = qw( Foswiki::Engine );

ModPerlEngineContrib/lib/Foswiki/Engine/Apache/MP13.pm

@@ -36,6 +36,7 @@ Refer to Foswiki::Engine documentation for explanation about methos below.
 package Foswiki::Engine::Apache::MP13;
 
 use strict;
+use warnings;
 use Foswiki::Engine::Apache;
 our @ISA = qw( Foswiki::Engine::Apache );
 

ModPerlEngineContrib/lib/Foswiki/Engine/Apache2.pm

@@ -36,6 +36,7 @@ Refer to the Foswiki::Engine documentation for further information.
 package Foswiki::Engine::Apache2;
 
 use strict;
+use warnings;
 use Foswiki::Engine::Apache;
 our @ISA = qw( Foswiki::Engine::Apache );
 

ModPerlEngineContrib/lib/Foswiki/Engine/Apache2/MP20.pm

@@ -36,6 +36,7 @@ Refer to Foswiki::Engine documentation for explanation about methos below.
 package Foswiki::Engine::Apache2::MP20;
 
 use strict;
+use warnings;
 use Foswiki::Engine::Apache2;
 our @ISA = qw( Foswiki::Engine::Apache2 );
 

PlainFileStoreContrib/test/unit/PlainFileStoreContrib/PlainFileStoreContribSuite.pm

@@ -1,5 +1,8 @@
 package PlainFileStoreContribSuite;
 
+use strict;
+use warnings;
+
 use Unit::TestSuite;
 our @ISA = qw( Unit::TestSuite );
 

PlainFileStoreContrib/test/unit/PlainFileStoreContrib/PlainFileStoreContribTests.pm

@@ -1,13 +1,11 @@
-use strict;
-
 package PlainFileStoreContribTests;
+use strict;
+use warnings;
 
+use Foswiki;
 use FoswikiTestCase;
 our @ISA = qw( FoswikiTestCase );
 
-use strict;
-use Foswiki;
-
 sub new {
     my $self = shift()->SUPER::new(@_);
     return $self;

QueryAcceleratorPlugin/lib/Foswiki/Plugins/QueryAcceleratorPlugin.pm

@@ -11,6 +11,7 @@ Plugin for an alternative query algorithm using DBCacheContrib
 package Foswiki::Plugins::QueryAcceleratorPlugin;
 
 use strict;
+use warnings;
 
 use Assert;
 

QueryAcceleratorPlugin/lib/Foswiki/Store/QueryAlgorithms/DBCache.pm

@@ -11,6 +11,7 @@ Part of QueryAcceleratorPlugin.
 
 package Foswiki::Store::QueryAlgorithms::DBCache;
 use strict;
+use warnings;
 
 #@ISA = ( 'Foswiki::Query::QueryAlgorithms' ); # interface
 

RenderFormPlugin/lib/Foswiki/Plugins/RenderFormPlugin.pm

@@ -19,6 +19,7 @@
 package Foswiki::Plugins::RenderFormPlugin;
 
 use strict;
+use warnings;
 
 use vars qw( $VERSION $RELEASE $REVISION $debug $pluginName );