Skip to content

Commit

Permalink
Item619: The configure extensions installer fails or at least warns a…
Browse files Browse the repository at this point in the history
…bout unsafe files.

Also improved the warning so that user reports will help us more in future


git-svn-id: http://svn.foswiki.org/trunk@1679 0b4bb1d4-4e5a-0410-9cc4-b2b747904278
  • Loading branch information
KennethLavrsen authored and KennethLavrsen committed Dec 31, 2008
1 parent b364bb7 commit 9d1ad9e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/lib/Foswiki/Configure/UIs/EXTEND.pm
Expand Up @@ -244,7 +244,7 @@ sub _listDir {
# evil. Check and untaint the filenames here.
# SMELL: potential problem with unicode chars in file names? (yes)
# TODO: should really compare to MANIFEST
if ($f =~ /^([-\w.]+)$/) {
if ($f =~ /^([-\w.,]+)$/) {
$f = $1;
if ( -d "$dir$path/$f" ) {
push( @names, "$path$f/" );
Expand All @@ -254,7 +254,7 @@ sub _listDir {
push( @names, "$path$f" );
}
} else {
print "WARNING: skipping possibly unsafe file (not able to shot it for the same reason :( )<br />\n";
print "WARNING: skipping possibly unsafe file $f (not able to shot it for the same reason :( )<br />\n";
}
}
closedir($d);
Expand Down

0 comments on commit 9d1ad9e

Please sign in to comment.