Skip to content

Commit

Permalink
Item12952: Fix regex, and report SMELL
Browse files Browse the repository at this point in the history
Back reference to /1 better written $1,

And report that autoconfigure is not working under FCGI.  Not sure
if this can be fixed.
  • Loading branch information
gac410 committed Sep 28, 2014
1 parent 7e3370a commit aaf37bd
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion core/lib/Foswiki/Configure/Wizards/AutoConfigureEmail.pm
Expand Up @@ -516,6 +516,11 @@ sub _autoconfigSMTP {
close STDERR;
open( my $fd2, ">/dev/null" ) or die "fd2: $!\n";
$tlog = '';

#SMELL: Does not work under FCGI
# at ../foswiki/distro/core/lib/Foswiki/Configure/Wizards/AutoConfigureEmail.pm line 302.
# Foswiki::Configure::Wizards::AutoConfigureEmail::__ANON__("Operation 'OPEN' not supported on FCGI::Stream handle

open( STDERR, '+>>', \$tlog ) or die "SSL logging: $!\n";
STDERR->autoflush(1);

Expand Down Expand Up @@ -623,7 +628,7 @@ sub _autoconfigSMTP {
close $fd2;
open( STDERR, '>&', $stderr ) or die "stderr:$!\n";
close $stderr;
$tlog =~ s/AUTH\s([^\s]+)\s.*$/AUTH \1 xxxxxxxxxxxxxxxx/mg;
$tlog =~ s/AUTH\s([^\s]+)\s.*$/AUTH $1 xxxxxxxxxxxxxxxx/mg;
$reporter->NOTE($tlog);

unless (@use) {
Expand Down

0 comments on commit aaf37bd

Please sign in to comment.