Item11666: fix default of radios and selects in forms to be as per docco

git-svn-id: http://svn.foswiki.org/trunk@14449 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

core/lib/Foswiki/Form.pm

@@ -434,6 +434,7 @@ sub renderForEdit {
             my $extra = '';    # extras on col 0
 
             unless ( defined($value) ) {
+
                 my $dv = $fieldDef->getDefaultValue($value);
                 if ( defined($dv) ) {
                     $dv    = $topicObject->expandMacros($dv);

core/lib/Foswiki/Form/Radio.pm

@@ -28,6 +28,12 @@ sub finish {
     undef $this->{valueMap};
 }
 
+# From System.DataForms, "The first item in the list for a select or
+# radio type is the default item."
+sub getDefaultValue {
+    return shift->getOptions()->[0];
+}
+
 sub getOptions {
     my $this = shift;
 

core/lib/Foswiki/Form/Select.pm

@@ -31,14 +31,13 @@ sub new {
 =begin TML
 
 ---++ getDefaultValue() -> $value
-The default for a select is always the empty string, as there is no way in
-Foswiki form definitions to indicate selected values. This defers the decision
-on a value to the browser.
+From System.DataForms, "The first item in the list for a select or
+radio type is the default item."
 
 =cut
 
 sub getDefaultValue {
-    return '';
+    return shift->getOptions()->[0];
 }
 
 sub getOptions {