Skip to content

Commit

Permalink
Item13546: enable store protection by default
Browse files Browse the repository at this point in the history
But add a warning suggesting that it be disabled if not planning any
migration from RCS.
  • Loading branch information
gac410 committed Jul 21, 2015
1 parent 61f5b7c commit be33ee3
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 2 deletions.
@@ -0,0 +1,53 @@
# See bottom of file for license and copyright information
package Foswiki::Configure::Checkers::Extensions::PlainFileStoreContrib::CheckForRCS;

use strict;
use warnings;

use Foswiki::Configure::Checker ();
our @ISA = ('Foswiki::Configure::Checker');

my @required = (

);

sub check_current_value {
my ( $this, $reporter ) = @_;

return
unless (
$Foswiki::cfg{Store}{Implementation} eq 'Foswiki::Store::PlainFile' );

if ( $Foswiki::cfg{Extensions}{PlainFileStoreContrib}{CheckForRCS} ) {
$reporter->WARN(
"This setting can be disabled for slightly improved performance once you can ensure that no RCS history exists within your Store."
);
}
}

1;
__END__
Foswiki - The Free and Open Source Wiki, http://foswiki.org/
Copyright (C) 2008-2015 Foswiki Contributors. Foswiki Contributors
are listed in the AUTHORS file in the root of this distribution.
NOTE: Please extend that file, not this notice.
Additional copyrights apply to some or all of the code in this
file as follows:
Copyright (C) 2000-2006 TWiki Contributors. All Rights Reserved.
TWiki Contributors are listed in the AUTHORS file in the root
of this distribution.
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version. For
more details read LICENSE in the root of this distribution.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
As per the GPL, removal of this notice is prohibited.
Expand Up @@ -13,6 +13,6 @@
# Check before every store modification that there are no suspicious
# files left over from RCS. This check should be enabled whenever there
# is a risk that old RCS data has been mixed in to a PlainFileStore.
$Foswiki::cfg{Extensions}{PlainFileStoreContrib}{CheckForRCS} = 0;
$Foswiki::cfg{Extensions}{PlainFileStoreContrib}{CheckForRCS} = 1;

1;
Expand Up @@ -5,4 +5,4 @@ lib/Foswiki/Contrib/PlainFileStoreContrib.pm 0644 Perl module
lib/Foswiki/Store/PlainFile.pm 0644 Perl module
lib/Foswiki/Contrib/PlainFileStoreContrib/Config.spec 0444 Configuration
lib/Foswiki/Configure/Checkers/Store/PlainFile/Implementation.pm 0644

lib/Foswiki/Configure/Checkers/Extensions/PlainFileStoreContrib/CheckForRCS.pm 0644

0 comments on commit be33ee3

Please sign in to comment.