Item15186: make auto-attach feature more robust

foswiki · Mar 2, 2023 · d5d5b87 · d5d5b87
1 parent 4da8f80
commit d5d5b87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/RCSStoreContrib/lib/Foswiki/Store/Rcs/Handler.pm b/RCSStoreContrib/lib/Foswiki/Store/Rcs/Handler.pm
@@ -1396,7 +1396,7 @@ sub synchroniseAttachmentsList {
 
     foreach my $file ( keys %filesListedInPub ) {
         if (   $filesListedInMeta{$file}
-            && $filesListedInMeta{$file}{date} !=
+            && $filesListedInMeta{$file}{date} <
             $filesListedInPub{$file}{date} )
         {
             # File timestamp of existing file has changed.

diff --git a/RCSStoreContrib/test/unit/RCSStoreContrib/AutoAttachTests.pm b/RCSStoreContrib/test/unit/RCSStoreContrib/AutoAttachTests.pm
@@ -154,7 +154,7 @@ sub verify_autoattach {
     $this->assert_not_null( $bfileAttributes,
         'bfile.txt is missing file attributes' );
     $this->assert_null( $bfileAttributes->{autoattached},
-        'bfile.txt shoud NOT be an autoattachment' );
+        'bfile.txt shoud NOT be an auto-attached' );
 
     # visibledirectory not autoattached.:
     my $visdirAttr = $meta->get( 'FILEATTACHMENT', "visibledirectory" );
@@ -187,12 +187,12 @@ sub verify_autoattach {
         'afile.txt incorrectly auto-attached'
     );
 
-    # Assert bfile.txt exists, and has changed to an autoattachment
+    # Assert bfile.txt exists, and has changed to an auto-attached
     $bfileAttributes = $meta->get( 'FILEATTACHMENT', "bfile.txt" );
     $this->assert_not_null( $bfileAttributes,
         'bfile.txt is missing file attributes' );
     $this->assert( $bfileAttributes->{autoattached},
-        'bfile.txt shoud now be an autoattachment' );
+        'bfile.txt shoud now be an auto-attached' );
 
     # Our added files now exist:
     my $sneakedfile1Attributes =