Item9347: isRedirectSafe tests must control the config

git-svn-id: http://svn.foswiki.org/trunk@8217 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

UnitTestContrib/test/unit/ResponseTests.pm

@@ -8,6 +8,14 @@ use Assert;
 
 use Foswiki::Response;
 
+sub set_up {
+    my $this = shift;
+    $this->SUPER::set_up();
+    $Foswiki::cfg{AllowRedirectUrl} = 0;
+    $Foswiki::cfg{DefaultUrlHost} = 'http://wiki.server';
+    $Foswiki::cfg{PermittedRedirectHostUrls} = 'http://other.wiki';
+}
+
 sub test_empty_new {
     my ($this) = @_;
     my $res  = Foswiki::Response->new();
@@ -268,11 +276,11 @@ sub test_isRedirectSafe {
     my ($this) = @_;
 
     $this->assert(not Foswiki::_isRedirectSafe('http://slashdot.org'));
+    $this->assert(Foswiki::_isRedirectSafe('/relative'));
 
     #$Foswiki::cfg{DefaultUrlHost} based
     my $baseUrlMissingSlash = $Foswiki::cfg{DefaultUrlHost};
 
-
     #http://wiki.server.com (missing trailing slash)
     $baseUrlMissingSlash =~ s/(.*)\/$/$1/;
     my $url = $baseUrlMissingSlash;
@@ -281,6 +289,21 @@ sub test_isRedirectSafe {
     $this->assert(Foswiki::_isRedirectSafe($url));
     $url = $baseUrlMissingSlash.'#header';
     $this->assert(Foswiki::_isRedirectSafe($url));
+
+    $Foswiki::cfg{DefaultUrlHost} = 'http://wiki.server';
+    $Foswiki::cfg{PermittedRedirectHostUrls} =
+      'http://wiki.other,http://other.wiki';
+
+    $this->assert(Foswiki::_isRedirectSafe('/wiki.server'));
+    $this->assert(Foswiki::_isRedirectSafe('http://wiki.server'));
+    $this->assert(Foswiki::_isRedirectSafe('http://wiki.server/'));
+    $this->assert(Foswiki::_isRedirectSafe('http://other.wiki'));
+    $this->assert(Foswiki::_isRedirectSafe('http://other.wiki/'));
+    $this->assert(Foswiki::_isRedirectSafe('http://wiki.other'));
+    $this->assert(Foswiki::_isRedirectSafe('http://wiki.other/'));
+    $this->assert(not Foswiki::_isRedirectSafe('http://slashdot.org'));
+    $this->assert(not Foswiki::_isRedirectSafe('http://slashdot.org/'));
+
     return;
 }