Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the order of files in foundation_and_overrides.scss #243

Closed
Kulgar opened this issue Sep 7, 2017 · 1 comment
Closed

Issue with the order of files in foundation_and_overrides.scss #243

Kulgar opened this issue Sep 7, 2017 · 1 comment

Comments

@Kulgar
Copy link

Kulgar commented Sep 7, 2017

Hi,

When we generate the files using rails g foundation:install, we get a strange import order in foundation_and_overrides.scss:

@include foundation-drilldown-menu;
@include foundation-dropdown;
@include foundation-dropdown-menu;
@include foundation-responsive-embed;
@include foundation-label;
@include foundation-media-object;
@include foundation-menu;
@include foundation-menu-icon;

As foundation-menu is included after foundation-dropdown, it overrides css rules (like display:none) when using a menu with dropdown because of the "menu" css class, breaking the dropdown functionality.

It should rather be:

@include foundation-responsive-embed;
@include foundation-label;
@include foundation-media-object;
@include foundation-menu;
@include foundation-menu-icon;
@include foundation-drilldown-menu;
@include foundation-dropdown;
@include foundation-dropdown-menu;

Don't you think?

Can you also check if there are some other misplaced includes?

@patricklindsay
Copy link
Contributor

This is fixed in #237. Just wanting on a merge @mehlah @mhayes @kball ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants