New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top bar not displaying navigation links at small browser widths (foundation-rails 5.1.1.0) #4456
Comments
Hi, I had also some trouble with the top-bar after the update to 5.1.1 -> because I had to edit my html :/ e.g.: old: li.toggle-topbar.menu-icon a span "Menu" new: li.toggle-topbar.menu-icon a "Menu" |
@voku thanks for the suggestion but it doesn't resolve the issue foe me. Removing the |
@DanielKehoe if you replace the div.top-bar-section like this -> http://codepen.io/voku/pen/edEAJ <- I think it will work again ... |
@voku thanks you for your efforts to help. It looks like the problem is an incompatibility with the Rails asset pipeline. To get it to work, it is necessary to change the html for the navigation bar:
Also, the Foundation JavaScript has to be removed from the Rails asset pipeline:
I can fix the HTML for the Top Bar for my apps but it looks like Zurb will have to address the incompatibility with the Rails asset pipeline. |
Opened an issue to address the incompatibility with the Rails asset pipeline: |
The gem foundation-rails version 5.2.0.0 (released March 6, 2014) resolves the issue. |
With Foundation 5.0.3, the top bar works correctly. At narrow browser widths, the menu icon appears, and clicking on the menu icon reveals a menu of navigation links.
After upgrading to foundation-rails 5.1.1.0, clicking on the top bar menu icon does nothing. The menu of navigation links is not revealed.
First reported by students using the learn-rails example application:
RailsApps/learn-rails#23
You can clone the learn-rails example application to reproduce the issue. In the Gemfile, use
gem 'foundation-rails', '5.0.3'
to see it work. Usegem 'foundation-rails', '5.1.1.0'
to see it fail.I've tried removing Rails Turbolinks and the issue is not resolved.
I've also tried changing the file views/layouts/application.html.erb and moving
<%= javascript_include_tag "application" %>
from the head section to the last line of the body section and the issue is not resolved.The text was updated successfully, but these errors were encountered: