Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show for parent link not working on medium #6617

Closed
joeworkman opened this issue Jun 9, 2015 · 2 comments
Closed

Show for parent link not working on medium #6617

joeworkman opened this issue Jun 9, 2015 · 2 comments

Comments

@joeworkman
Copy link
Member

Issues #6393 definitely fixed the bug where the parent link was shown in the submenu, even on desktop. However, mobile_show_parent_link now only show for small only because the hide-for-medium-up is hard coded into Top Bar. What if I wanted to show the mobile menu on medium?

It would be nice if this were either an option. Or maybe there could be a way to intelligently figure out where the Top Bar mobile breakpoint is set. Then use the proper hide class based on that.

@vita10gy
Copy link

vita10gy commented Jun 9, 2015

There is a change for this in the pipeline.

#6538

Basically, there is already a media query for top bar. The change would create visibility classes based on that breakpoint and then use them where it's hard coded in the menu to show for small only (in this case the relevant one would be hide-for-top-bar-desktop-up).

It's an odd hardcoded default for it, since by default the top-bar is set to medium, so, if anything, one would think it should have been hide-for-large-up.

@rafibomb
Copy link
Member

@vita10gy Thanks for the PR! I think this will solve @joeworkman use case as well. We're testing it soon for merge. We'll close this here.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants