Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide-for-... classes not handling spans #887

Closed
Paul-Todd opened this issue Sep 15, 2012 · 1 comment
Closed

hide-for-... classes not handling spans #887

Paul-Todd opened this issue Sep 15, 2012 · 1 comment

Comments

@Paul-Todd
Copy link

Hi,

If I have a span with a hide-for-small it changes the display: from an inline variant to a block variant and this causes for example a button to wrap to the next line.

e.g. span should default to the button's display which is an inline-block but in face the hide-for-small replaces it with a plain block to in my case I had an icon before which forced the text onto a new line.

Photo

@bmatzner
Copy link
Contributor

bmatzner commented Oct 3, 2012

To go one step further: why do the hide-for classes define a default display: block state at all? The default display state should be defined on application level, not by Foundation. hide-for shouldn't do anything but hide at a certain point.
The same principle should apply to show-for classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants