Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Bug with a computer (and tablet) that has a touch screen #9652

Closed
IllusionPerdu opened this issue Jan 16, 2017 · 7 comments
Closed

[Menu] Bug with a computer (and tablet) that has a touch screen #9652

IllusionPerdu opened this issue Jan 16, 2017 · 7 comments

Comments

@IllusionPerdu
Copy link
Contributor

How to reproduce this bug:

  1. Go to : http://foundation.zurb.com/sites/docs/
  2. with a touch screen tap for exemple "Tutorial"
    => the menu open
  3. try to tap a submenu example : "Lessons"
    => the menu close an don't open the page

What should happen:

the page sould open the link

What happened instead:

=> the menu close and nothing

The problem is reproductible with
=> chrome on windows 10
=> firefox on windows 10
=> edge on windows 10
=> chrome on android device

@IllusionPerdu IllusionPerdu changed the title BUG in menu of the site doc BUG in menu Jan 16, 2017
@IamManchanda
Copy link
Contributor

IamManchanda commented Jan 16, 2017

First of all, are you talking about phones or tablets ?

Because there is no such menu -> submenu in mobile
there is only hamburger menu which opens a menu and all the links are there only


On tablet , yes there is such issue, just checked up and within docs only !

cc / @ncoden

@IllusionPerdu
Copy link
Contributor Author

IllusionPerdu commented Jan 16, 2017

I have view this bug with a computer or tablet no with a tel ;)

I don't know why but in some page in the foundation site the menu work.

@IllusionPerdu
Copy link
Contributor Author

The code example of the page http://foundation.zurb.com/sites/docs/dropdown-menu.html was affected it's don't change the hash with tap

@IllusionPerdu IllusionPerdu changed the title BUG in menu [Menu] Bug with a computer (and tablette) that has a touch screen Jan 16, 2017
@IllusionPerdu IllusionPerdu changed the title [Menu] Bug with a computer (and tablette) that has a touch screen [Menu] Bug with a computer (and tablet) that has a touch screen Jan 16, 2017
@IamManchanda
Copy link
Contributor

IamManchanda commented Jan 16, 2017

Just had some testing and yup this is a issue with touch screen!

Also, this bug is not related to docs
but actually with the framework's dropdown menu !

@IamManchanda
Copy link
Contributor

IamManchanda commented Jan 16, 2017

In short ,

This is a bug specific to Dropdown Menu. The Links are not clickable on any submenu of the dropdown menu within any Touch Screen devices(mobile, desktop, tablet, etc) !

Thanks for reporting.

cc / @kball @gakimball

@IllusionPerdu
Copy link
Contributor Author

IllusionPerdu commented Jan 24, 2017

I don't know if is oki after this change in /js/foundation.dropdownMenu.js aparently it work

        // Handle Leaf element Clicks
        if (_this.options.closeOnClickInside) {
          this.$menuItems.on('click.zf.dropdownmenu touchend.zf.dropdownmenu', function (e) {
            var $elem = $(this),
                hasSub = $elem.hasClass(parClass);
            if (!hasSub) {
              return true;      //this is added
              //_this._hide();  //this is remove
            }
          });
        }

@IllusionPerdu
Copy link
Contributor Author

in the develop branch it's ok ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants