Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctness failure with "Attempting to change status of a different index build" #52

Closed
apkar opened this issue Jan 29, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@apkar
Copy link
Contributor

apkar commented Jan 29, 2019

Occasional failures not reproducible with any specific seed, but reproduce in 1 out of 4000 runs.

@apkar apkar added the bug Something isn't working label Jan 29, 2019
@apkar apkar added this to the 1.7 milestone Jan 29, 2019
@dongxinEric dongxinEric self-assigned this Mar 5, 2019
@apkar
Copy link
Contributor Author

apkar commented Mar 19, 2019

If a transaction is failed while updating the index status, failure handler (catch block) would try to update the status to error. But, it is possible transaction has failed even before index status was set causing the buildId to mismatch. This needs to be fixed properly with transaction management. Delaying that until #68. #121 just makes this error more explicit and tries to make the contract more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants