Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Upstreaming the assertions to PRBTest #128

Closed
PaulRBerg opened this issue Jul 15, 2022 · 1 comment
Closed

Meta: Upstreaming the assertions to PRBTest #128

PaulRBerg opened this issue Jul 15, 2022 · 1 comment

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jul 15, 2022

This discussion is contingent on bumping the pragma to >=0.8.0 <0.9.0.

Building up on the arguments I have made in Why Choose PRBTest Over DSTest?:

  1. Switching to PRBTest would free Forge Std of the path dependence problem that plagues DSTest (that is, all DappHub projects depend upon DSTest, so updating it is painful to orchestrate). PRBTest is a brand new project, and I have designed it from the get go to never suffer from path dependence.
  2. Letting PRBTest handle all testing assertions would take a burden off the shoulders of Forge Std. Forge Std could instead focus on its juiciest features, such as StdStorage, and could continue "moving fast and breaking things" knowing that unless PRBTest is explicitly version bumped, the assertion syntax will remain the same.
  3. Forge Std wouldn't have to maintain the Vm interface anymore.
  4. Forge Std wouldn't have to maintain the tests in StdAssertions.t.sol anymore.
  5. PRBTest has a more permissive license than DSTest. MIT versus GPL v3.

Finally, on a personal level, Foundry has become my primary development framework. It's what I recommend to anyone looking to jump into Ethereum development. I've also recently become a frequent contributor to Forge Std and the Foundry Book. Upstreaming the assertions to PRBTest would make us both more agile.

@ZeroEkkusu
Copy link
Collaborator

Closing, as discussed in #139.

@ZeroEkkusu ZeroEkkusu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants