-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#51 breaks backwards compatibility before 0.8.0
#53
Comments
0.8.0
Great catch, thanks! Seems we can just change the @ZeroEkkusu We should probably update the CI to run against a few different solc versions, since this has happened before |
If you don't have unchecked, the following will fail: int256 inverse = -(type(int256).min) |
This is correct. |
Assuming we don't want to raise the minimum solidity version, I'm leaning towards #54 |
Description
Recently #51 was merged and it included an
unchecked
in thestdMath.abs
function, which requires to bump the Solidity version for theforge-std
package to bepragma solidity >=0.8.0 <0.9.0;
instead ofpragma solidity >=0.6.0 <0.9.0;
I'm myself running into an issue here since I wanted to test a
0.6.0
contract and this was broken. You either will need to remove theunchecked
or bump the version.The text was updated successfully, but these errors were encountered: