Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardhat issue https://github.com/NomicFoundation/hardhat/pull/2581 #1297

Closed
aathan opened this issue Apr 13, 2022 · 2 comments
Closed

Hardhat issue https://github.com/NomicFoundation/hardhat/pull/2581 #1297

aathan opened this issue Apr 13, 2022 · 2 comments

Comments

@aathan
Copy link
Contributor

aathan commented Apr 13, 2022

I installed hardhat with the patch from their NomicFoundation/hardhat#2581 (which is in their branch test-helpers) and now hardhat emits this log when running the problem Foundry test in #1287:

I don't have much more time to devote to this but wanted to report that here because additional coordination may be needed between the projects, or hardhat's fix is incorrect?

eth_getStorageAt

  Errors encountered in param 1: Invalid value "0x0000000000000000000000000000000000000000000000000000000000000003" supplied to : QUANTITY

Per the discussion at #1287:

Confirmed to be a Hardhat issue, see #1287 (reply in thread) (or just NomicFoundation/hardhat#2581)

Originally posted by @onbjerg in #1287 (comment)

@aathan
Copy link
Contributor Author

aathan commented Apr 13, 2022

It looks like I actually didn't run the full set of fixes for their 2581 issue. I don't want to waste anyone's time so I'll stop here.

@aathan
Copy link
Contributor Author

aathan commented Apr 13, 2022

I was able to pull all the commits from their patch and verify that those fixes resolve this problem. Closing this Issue.

@aathan aathan closed this as completed Apr 13, 2022
@aathan aathan changed the title Harhat issue https://github.com/NomicFoundation/hardhat/pull/2581 Hardhat issue https://github.com/NomicFoundation/hardhat/pull/2581 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant