Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge fmt introduces trailing whitespace in multiline comments #2597

Closed
2 tasks done
0xCLARITY opened this issue Aug 3, 2022 · 1 comment
Closed
2 tasks done

forge fmt introduces trailing whitespace in multiline comments #2597

0xCLARITY opened this issue Aug 3, 2022 · 1 comment
Assignees
Labels
C-forge Command: forge Cmd-forge-fmt Command: forge fmt T-bug Type: bug
Milestone

Comments

@0xCLARITY
Copy link

0xCLARITY commented Aug 3, 2022

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (01325bc 2022-08-03T00:04:48.802271Z)

What command(s) is the bug in?

forge fmt

Operating System

macOS (Apple Silicon)

Describe the bug

I would expect this block comment to be formatted as shown:

    /**
     * Does this add a whitespace error?
     *
     * Let's find out.
     */

However, when I run forge fmt, it adds a trailing whitespace behind the middle asterisk:

    /**
     * Does this add a whitespace error?
-    *
+    *  
     * Let's find out.
     */

git warns me that this is a whitespace error.

Happy to contribute a PR if I'm pointed to the relevant code.

@0xCLARITY 0xCLARITY added the T-bug Type: bug label Aug 3, 2022
@onbjerg onbjerg added C-forge Command: forge Cmd-forge-fmt Command: forge fmt labels Aug 4, 2022
@onbjerg onbjerg added this to the v1.0.0 milestone Aug 4, 2022
@rkrasiuk rkrasiuk self-assigned this Aug 4, 2022
@mattsse
Copy link
Member

mattsse commented Aug 4, 2022

closed by #2600

@mattsse mattsse closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-fmt Command: forge fmt T-bug Type: bug
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants