Add support for Solidity 0.8.18

[pcaversaccio]

The new Solidity release 0.8.18 should be released this or next week (see here). I already opened an issue to track the support status in Foundry in one place.

[mattsse]

@roynalnaruto heads up

[roynalnaruto]

PR open here: alloy-rs/svm-rs#73

Edit:
We need https://github.com/nikitastupin/solc to be updated @nikitastupin would you be able to manually trigger the build and publish workflow?

[pcaversaccio]

FYI for anyone that is interested in the release notes: https://github.com/ethereum/solidity/releases/tag/v0.8.18

[nikitastupin]

Hey everyone! I've uploaded v0.8.18 at nikitastupin/solc@01a11ef cc @roynalnaruto

[roynalnaruto]

Related PR: gakonst/ethers-rs#2110

[pcaversaccio]

Not sure whether this impacts this issue, but I discovered yesterday an issue with the Linux binary builds of solc 0.8.18: ethereum/solidity#13921. The binary has been rebuilt and now has another hash.

[nikitastupin]

I tried solc --version with linux aarch64 build and it didn't have this problem so I assume no need to recompile

[mattsse]

@roynalnaruto this could be the root cause for the headers mismatch?

[roynalnaruto]

@mattsse I don't think so. The SHA256 checksum for the Linux AARCH64 architecture was built by @nikitastupin and I got the checksum locally. Could you also try if that binary's SHA256 checksum is the same as what we have here:

https://github.com/roynalnaruto/svm-rs/blob/master/list/linux-aarch64.json ?

[roynalnaruto]

The binaries will be fetched from @nikitastupin 's solc repository, so as long as that binary hasn't been updated, the checksum can't fail?

[mattsse]

CI errors could be related to ethereum/solidity#13921

in any case we should improve the svm ChecksumMismatch error so it includes the expected and actual, otherwise this isn't very helpful

[pcaversaccio]

as a quick input, I like how solc-select verifies the checksums: https://github.com/crytic/solc-select/blob/dev/solc_select/solc_select.py#L121. Like that we could easily detect the cache problem re the binaries (see my solc issue for more info on that).

[leekt]

Seems there are still issues with parsing the 0.8.18 and this issue exists on solang-parser
cannot do forge fmt and forge doc for something like this

pragma solidity ^0.8.18;

contract C {
    mapping(address user => uint256) public balances;
}

[mattsse]

yeh since this is a new language feature, I don't think this is supported yet by https://github.com/hyperledger/solang
please consider opening an issue there

[leekt]

done hyperledger/solang#1159