You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, not sure if I should upload this issue here or in foundry repo, but with the implementation of this commit: foundry-rs/forge-std@1432518 the behavior of assertEq changed (and I assume the others as well). It is now reverting and stopping execution instead of throwing a simple log and test failure.
I would believe this behavior change is not intended and we'd want to still stick with the original one (referred from example here:
This was intended behavior. Do you have a use case for continuing execution after failure? If so, perhaps it's feasible to add a flag to toggle the behavior used
This was intended behavior. Do you have a use case for continuing execution after failure? If so, perhaps it's feasible to add a flag to toggle the behavior used
Nothing too specific but in general when running the tests for first time is nice to catch all the possible errors at once for correcting them (whatever they are contract or test ones) than having to fix it, run again, fix, run again...
Thank you for the feedback. I have also thought this a few times, e.g. when making a large change and expecting a lot of assertions to fail. cc @klkvr for thoughts
Hey, not sure if I should upload this issue here or in foundry repo, but with the implementation of this commit: foundry-rs/forge-std@1432518 the behavior of
assertEq
changed (and I assume the others as well). It is now reverting and stopping execution instead of throwing a simple log and test failure.I would believe this behavior change is not intended and we'd want to still stick with the original one (referred from example here:
foundry/crates/evm/evm/src/executors/mod.rs
Line 426 in 651cec1
The text was updated successfully, but these errors were encountered: