hardhat-forge: ignore metadata files #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting contract artifacts, json files are pulled out of the artifacts directory. Since metadata files are now emitted by default as of foundry-rs/foundry@ad91a4a, extra files were being passed through the hh artifact generation pipeline which broke things because the hardhat artifacts need the fully qualified name which is currently pulled from the ast in the compiler out. It could be possible to brute force the fully qualified name but that would fail when 2 contracts have a matching name. This filters out the metadata files when getting the contract artifacts.
🦋 Changeset detectedLatest commit: 3211bab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting contract artifacts, json files are pulled out of
the artifacts directory. Since metadata files are now emitted by
default as of
foundry-rs/foundry@ad91a4a,
extra files were being passed through the hh artifact generation
pipeline which broke things because the hardhat artifacts need
the fully qualified name which is currently pulled from the
ast in the compiler out. It could be possible to brute force
the fully qualified name but that would fail when 2 contracts
have a matching name. This filters out the metadata files
when getting the contract artifacts.
This fixes our broken CI