Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the parsing of sierra input function types from forge to USC #2046

Closed
Arcticae opened this issue Apr 18, 2024 · 2 comments
Closed

Move the parsing of sierra input function types from forge to USC #2046

Arcticae opened this issue Apr 18, 2024 · 2 comments

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Apr 18, 2024

Which components does the task require to be changed? (think hard pls)

snforge

Description

We should add a hidden API in USC in order to achieve full independence of sierra, and/or parsing the structures that we don't own.

It should be contained in USC via a hidden API (like unsafe_... features in scarb for profiler)

We use those types structures for:

It should be assessed whether we can be fully independent of sierra (and sierra-dependent) crates

@piotmag769
Copy link
Member

For creating the entry code all the compiler really need to know that is sierra specific are the names of the args (GenericTypeId is basically a newtype for SmolStr), we can prob just change the interface in the compiler

@Arcticae Arcticae self-assigned this Apr 19, 2024
@Arcticae Arcticae removed the new label Apr 22, 2024
@Arcticae Arcticae closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@Arcticae
Copy link
Contributor Author

Not relevant after plugins migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants