Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheatcode mocking get_block_hash_syscall #684

Open
MaksymilianDemitraszek opened this issue Sep 18, 2023 · 4 comments
Open

Cheatcode mocking get_block_hash_syscall #684

MaksymilianDemitraszek opened this issue Sep 18, 2023 · 4 comments
Labels
feature New feature request/description good first issue Good for newcomers Team: snforge

Comments

@MaksymilianDemitraszek
Copy link
Member

// Gets the block hash of the block with the given number.
extern fn get_block_hash_syscall(
    block_number: u64
) -> SyscallResult<felt252> implicits(GasBuiltin, System) nopanic;

not urgent, not requested by anybody

@duralsh
Copy link
Contributor

duralsh commented Nov 8, 2023

I can potentially work on this as my next task. Where can i get more information about this issue ?

@Arcticae
Copy link
Contributor

Arcticae commented Nov 8, 2023

@partychad we need to come up with a cheatcode name which mocks the get_block_hash syscall, and implement it in a similar way that others are implemented. I don't think there's much information available apart from that.

get_block_hash works kind of like regular contract call from what i understand, if that helps

@duralsh
Copy link
Contributor

duralsh commented Nov 9, 2023

I want to start working on this issue once my open PRs are merged, if it is okay :)

@Arcticae
Copy link
Contributor

@partychad you are free to assign yourself if you still want it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request/description good first issue Good for newcomers Team: snforge
Projects
Status: Triage
Development

No branches or pull requests

3 participants