Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performing an erroneous update to an EmbeddedCollectionField breaks references to the field's source #10648

Closed
Fyorl opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Functionality which is not working as intended data-models Issues related to data models and schema changes

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Apr 16, 2024

console.log(actor._source.items === actor.items._source); // true

// Dry-run update
actor.updateSource({ items: [{ name: 'foo', type: 'weapon' }] }, { dryRun: true });
console.log(actor._source.items === actor.items._source); // true

// Erroneous update
try { actor.updateSource({ items: [{ name: 'foo' }] }); } catch {}
console.log(actor._source.items === actor.items._source); // false
@Fyorl Fyorl added bug Functionality which is not working as intended data-models Issues related to data models and schema changes labels Apr 16, 2024
@Fyorl Fyorl added this to the V12 - API Development 2 milestone Apr 16, 2024
@Fyorl Fyorl self-assigned this Apr 16, 2024
@Fyorl Fyorl removed this from the V12 - API Development 2 milestone Apr 18, 2024
@aaclayton aaclayton added this to the V12 - User Testing 1 milestone Apr 18, 2024
@Fyorl Fyorl removed this from the V12 User Testing 2 milestone May 2, 2024
@Fyorl Fyorl added this to the V12 User Testing 4 milestone May 16, 2024
@Fyorl Fyorl closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended data-models Issues related to data models and schema changes
Projects
Status: Done
Development

No branches or pull requests

2 participants