Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made async drag event handler functions non-async #10765

Closed
dev7355608 opened this issue Apr 26, 2024 · 0 comments
Closed

Made async drag event handler functions non-async #10765

dev7355608 opened this issue Apr 26, 2024 · 0 comments
Assignees
@dev7355608
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions.
Milestone
V12 User Testing ...

Comments

@dev7355608
Copy link

dev7355608 commented Apr 26, 2024 •
edited

The following functions are no longer async:

  • InteractionLayer#_onDragLeftStart
  • InteractionLayer#_onDragLeftDrop
  • PlaceableObject#_onDragLeftDrop
  • Drawing#_onHandleDragDrop
  • Tile#_onHandleDragDrop
@dev7355608 dev7355608 added bug Functionality which is not working as intended api Issues related to the API used by Mod Devs canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. labels Apr 26, 2024
@dev7355608 dev7355608 self-assigned this Apr 26, 2024
@aaclayton aaclayton changed the title Event drag handler functions shouldn't be async Ensure that dragLeftMove and dragRightMove handlers fire immediately when a drag start operation occurs. Apr 29, 2024
@aaclayton aaclayton added this to the V12 User Testing 2 milestone Apr 29, 2024
@dev7355608 dev7355608 changed the title Ensure that dragLeftMove and dragRightMove handlers fire immediately when a drag start operation occurs. Made async drag event handler functions non-async May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dev7355608 dev7355608

Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions.
Projects
Foundry VTT - Version 12
Status: Done
Milestone
V12 User Testing 2 - 12.321
Development

No branches or pull requests
2 participants
@aaclayton @dev7355608