Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain the "entity" field in PackageCompendiumData so that worlds which are migrated to v9 can (potentially) be reverse migrated back to v8. #6060

Closed
Fyorl opened this issue Nov 5, 2021 · 3 comments
Assignees
Labels
bug Functionality which is not working as intended packages Issues related to add-on packages, systems, modules, and worlds

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Nov 5, 2021

Originally in GitLab by @Fyorl

Originally reported by KaKaRoTo#1337 https://discord.com/channels/170995199584108546/872553750877835264/905941392159834163

Short description of bug: World will disappear from Foundry setup when downgrading from v9 to 0.8.x
Details:
Reporting here as suggested by @cswendrowski so it can be fixed before stable.
If you upgrade to v9 (for testing purposes or because it's now stable), the world.json gets migrated where compendium packs get the entity field changed into type. This means that downgrading back to 0.8.x will cause the world to completely disappear from the setup page.
Error logs show that Foundry rejects the package because of the missing required field entity in CompendiumData.
While DB migration could cause a world to misbehave, and downgrades aren't technically supported, it is a common use case that people need to revert (broken modules, or game breaking bugs, or other) and not having the world completely disappear could help prevent a lot of tech support requests and user headaches.

@Fyorl
Copy link
Contributor Author

Fyorl commented Nov 5, 2021

Originally in GitLab by @Fyorl

I think we recommend that people take backups of their worlds before updating foundry versions so those worlds can be restored if they need to revert, so I'm not sure if we should be making allowances for these sorts of cases. If not though, it should be reasonably easy to retain the entity field in the CompendiumData and not delete it.

@Fyorl
Copy link
Contributor Author

Fyorl commented Dec 8, 2021

Originally in GitLab by @kakaroto

This doesn't look like it was fixed. I think the world.json will still not have the entity field if it's not part of the pack's schema, when the manifest gets re-written.

A user reported the same issue today and after I checked their world.json, it didn't show entity.

image

This was marked fixed on v9 Dev 2, but the user only had access to v9 Testing 1 (9.233). Please re-open and re-scope it before stable.

Thanks.

@Fyorl
Copy link
Contributor Author

Fyorl commented Dec 8, 2021

Originally in GitLab by @anathemamask

Still occurring in v9t1 world pack definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended packages Issues related to add-on packages, systems, modules, and worlds
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants