Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The core rollMode setting defaults to an invalid choice #6429

Closed
mattexdee opened this issue Jan 3, 2022 · 0 comments
Closed

The core rollMode setting defaults to an invalid choice #6429

mattexdee opened this issue Jan 3, 2022 · 0 comments
Assignees
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended dice Issues related to dice rolling and the Dice system

Comments

@mattexdee
Copy link
Contributor

Originally in GitLab by @mattexdee

Originally posted by Ghost here: https://discord.com/channels/170995199584108546/872553750877835264/925486098346553394

  • ALL MODULES DISABLED? true
  • OS, Hosting, Browser (if applicable): Not applicable
  • Short Description of bug: The core setting rollMode defaults to "roll" which is not one of the choices. This is not a big problem because it's handled by ChatMessage#applyRollMode but modules / systems might depend on this being consistent.
  • Simple steps to reproduce the bug: Start foundry in a new client (or incognito tab), open some world, execute game.settings.get("core", "rollMode") in the console and see that it's roll instead of the expected publicroll.

Note: I have reproduced this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended dice Issues related to dice rolling and the Dice system
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants