Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return type of Folder#createDialog is documented incorrectly #6619

Closed
aaclayton opened this issue Jan 27, 2022 · 0 comments
Closed

Return type of Folder#createDialog is documented incorrectly #6619

aaclayton opened this issue Jan 27, 2022 · 0 comments
Assignees
Labels
bug Functionality which is not working as intended documentation Improvements or additions to documentation

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @ghost91-

Environment Details

  • Foundry VTT Version: v9.245

Issue Description

In v9.245, Folder#createDialog was adjusted so that it returns the created document (or null if the FolderConfig is closed), which brings it in line with how ClientDocumentMixin#createDialog works (thanks for that!). However, it looks like the documentation was not adjusted accordingly. It still reads as follows:

   * @return {Application}      An active FolderConfig instance for creating the new Folder document

It should be adjusted to match the new (correct) behavior.

@aaclayton aaclayton self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended documentation Improvements or additions to documentation
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant