Foundry no longer displays successful socket reconnection

[aaclayton]

Originally in GitLab by @kakaroto

Something I noticed today while testing, if a user loses websocket connection for some reason, Foundry would show the notification "You have lost connection to the server, attempting to re-establish.", but there's no further notifications, even after the socket has reconnected.

I know that Foundry used to display the successful reconnection message in previous versions, but now it doesn't anymore, and I realized that users will refresh the page even though it immediately reconnected successfully, simply because they don't get that feedback that the connection was re-established.

Looking at foundry.js, I can still see it :

    // Reconnect succeeded
    this.socket.on('reconnect', () => {
      ui.notifications.info("Server connection re-established.");
    });

However, I know that you upgraded from socket.io v2 to v3 recently and according to this : https://socket.io/docs/v3/migrating-from-2-x-to-3-0/, you need to use this.socket.io.on('reconnect' instead of this.socket.on('reconnect' :

Thanks.

[aaclayton]

Thanks for the heads up about this change, would have been nice for them to log a warning or something if you were using the wrong (old) event syntax.