Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shutting down a world with a Journal Entry Page open causing the ProseMirrorAuthority to throw an error #7542

Closed
Fyorl opened this issue Jul 18, 2022 · 0 comments
Assignees
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Jul 18, 2022

Originally reported by ghost#2000 https://discord.com/channels/170995199584108546/956306859491471420/998255378431234200

ALL MODULES DISABLED? true
OS, Hosting, Browser (if applicable): Arch Linux, nodejs, Chromium
Short Description of bug: Got a weird error message in the console running the nodejs app, something about prosemirror.
Simple steps to reproduce the bug: I just shut down a world, but no idea if it's reproducible reliably.
Screenshots and/or console errors:

FoundryVTT | 2022-07-17 17:48:00 | [error] Cannot read properties of undefined (reading 'find')
TypeError: Cannot read properties of undefined (reading 'find')
    at Function.#l (file:///home/johannesloher/Games/FoundryVTT-10.273/resources/app/dist/components/prosemirror.mjs:1:2765)
    at Socket.emit (node:events:532:35)
    at Socket.emit (node:domain:475:12)
    at Socket.emitReserved (/home/johannesloher/Games/FoundryVTT-10.273/resources/app/node_modules/socket.io/dist/typed-events.js:56:22)
    at Socket._onclose (/home/johannesloher/Games/FoundryVTT-10.273/resources/app/node_modules/socket.io/dist/socket.js:357:14)
    at Client.onclose (/home/johannesloher/Games/FoundryVTT-10.273/resources/app/node_modules/socket.io/dist/client.js:246:20)
    at Socket.emit (node:events:532:35)
    at Socket.emit (node:domain:475:12)
    at Socket.onClose (/home/johannesloher/Games/FoundryVTT-10.273/resources/app/node_modules/engine.io/build/socket.js:304:18)
    at Object.onceWrapper (node:events:639:28)
@Fyorl Fyorl added bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems api Issues related to the API used by Mod Devs labels Jul 18, 2022
@Fyorl Fyorl added this to the Version 10 - Testing 1 milestone Jul 18, 2022
@Fyorl Fyorl self-assigned this Jul 26, 2022
@Fyorl Fyorl removed their assignment Aug 3, 2022
@Fyorl Fyorl self-assigned this Aug 9, 2022
@Fyorl Fyorl closed this as completed Aug 10, 2022
@Fyorl Fyorl changed the title Shutting down a world can cause the ProseMirrorAuthority to throw an error Fixed shutting down a world with a Journal Entry Page open causing the ProseMirrorAuthority to throw an error Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants