You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PointSource#_createPolygon/_createRestrictedPolygon doesn't have to return a ClockwiseSweepPolygon. If it doesn't, this.los.edges.size fails. los.edge seems to be always nonempty unless los.points is empty, which would mean that this check doesn't have any effect.
// LightSource#initialize// Compute the source polygonthis.los=this._createPolygon();this._flags.renderSoftEdges&&=((this.los.edges.size>0)||(this.data.angle<360));
// VisionSource#initialize// Compute the unrestricted line-of-sight polygonthis.los=this._createPolygon();// Compute the constrained vision polygonthis.fov=this._createRestrictedPolygon();// Render soft edges according to performances modethis._flags.renderSoftEdges=canvas.performance.lightSoftEdges&&((this.fov.edges.size>0)||(this.data.angle<360));
(_createRestrictedPolygon's return type should be PointSourcePolygon | PIXI.Polygon: the same as _createPolygon.)
What ways of accessing Foundry can you encounter this issue in?
Native App (Electron)
Chrome
Firefox
Safari
Other
Reproduction Steps
.
What core version are you reporting this for?
Version 10 Testing 4 (build 278)
Relevant log output
No response
Bug Checklist
The issue occurs while all Modules are disabled
The text was updated successfully, but these errors were encountered:
Feu-Secret
changed the title
LightSource/VisionSource#initialize breaks if los is not a ClockwiseSweepPolygon
The method to know if a vision or light source polygon could benefit from a fast triangulation was not working anymore.
Aug 30, 2022
What happened?
PointSource#_createPolygon/_createRestrictedPolygon
doesn't have to return aClockwiseSweepPolygon
. If it doesn't,this.los.edges.size
fails.los.edge
seems to be always nonempty unlesslos.points
is empty, which would mean that this check doesn't have any effect.(
_createRestrictedPolygon
's return type should bePointSourcePolygon | PIXI.Polygon
: the same as_createPolygon
.)What ways of accessing Foundry can you encounter this issue in?
Reproduction Steps
.
What core version are you reporting this for?
Version 10 Testing 4 (build 278)
Relevant log output
No response
Bug Checklist
The text was updated successfully, but these errors were encountered: