Correct an issue in foundry.utils.randomID with double-weight on the "9" character.

[ghost91-]

What happened?

foundry.utils.randomID is documented to generate IDs of the length given as parameter. However, it always creates IDs of length 16.

Additionally, the possible characters contain 9 twice, so 9 is slightly more likely in the generated ids than any other character.

The current implementation is

export function randomID(length=16) {
  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz09123456789";
  const r = Array.from({length: 16}, () => (Math.random() * 63) >> 0);
  return r.map(i => chars[i]).join("");
}

but it should probably be something like

export function randomID(length=16) {
  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
  const r = Array.from({length}, () => (Math.random() * chars.length) >> 0);
  return r.map(i => chars[i]).join("");
}

instead.

What ways of accessing Foundry can you encounter this issue in?

• Native App (Electron)
• Chrome
• Firefox
• Safari
• Other

Reproduction Steps

• Call foundry.utils.randomID(1)
• Observe that the result is a string with 16 characters

What core version are you reporting this for?

Version 10 Testing 4 (build 278)

Relevant log output

No response

Bug Checklist

• The issue occurs while all Modules are disabled