Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Reset Advanced Options" button on the Ambient Light configuration form should reset the preview and values of the form but not save the changes unless the user confirms "Update Light Source" #7887

Closed
1 of 6 tasks
dev7355608 opened this issue Aug 20, 2022 · 0 comments
Closed
1 of 6 tasks

The "Reset Advanced Options" button on the Ambient Light configuration form should reset the preview and values of the form but not save the changes unless the user confirms "Update Light Source" #7887

dev7355608 opened this issue Aug 20, 2022 · 0 comments
Assignees
@aaclayton
Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war
Milestone
Version 10 - Test...

Comments

@dev7355608
Copy link

What happened?

- this.document.updateSource(defaults);
+ foundry.utils.mergeObject(this.document, defaults);

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Place a light source and set Luminosity to -1. Close the config and reopen it. Click Reset Defaults and then close the config.

Result: Light source preview is not reset back to Luminosity -1.

What core version are you reporting this for?

Version 10 Testing 4 (build 278)

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Aug 20, 2022
@dev7355608 dev7355608 changed the title AmbientLightConfig#_resetDefaults updates the source of the document instead of the document `AmbientLightConfig#_onResetForm updates the source of the document instead of the document Aug 20, 2022
@dev7355608 dev7355608 changed the title `AmbientLightConfig#_onResetForm updates the source of the document instead of the document AmbientLightConfig#_onResetForm updates the source of the document instead of the document Aug 20, 2022
@aaclayton aaclayton added the lighting/fog Issues related to dynamic lighting or fog of war label Aug 21, 2022
@aaclayton aaclayton added this to the Version 10 - Testing 5 milestone Aug 21, 2022
@aaclayton aaclayton self-assigned this Aug 21, 2022
@aaclayton aaclayton changed the title AmbientLightConfig#_onResetForm updates the source of the document instead of the document The "Reset Advanced Options" button on the Ambient Light configuration form should reset the preview and values of the form but not save the changes unless the user confirms "Update Light Source" Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaclayton aaclayton

Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war
Projects
No open projects
Foundry VTT - Version 10
Status: Done
Milestone
Version 10 - Testing 5
Development

No branches or pull requests
2 participants
@aaclayton @dev7355608