Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance on scenes with large numbers of tiles significantly worse in v10 #8019

Closed
3 of 6 tasks
Sky-Captain-13 opened this issue Aug 31, 2022 · 0 comments
Closed
3 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended performance Issues related to application performance optimization tiles Issues related to Tiles and their appearance

Comments

@Sky-Captain-13
Copy link

What happened?

Performance in scenes with admittedly excessive numbers of tiles is significantly worse in v10 than in prior versions of Foundry. In v9, toggling the visibility state of a single tile was near instant and multiple uses of a macro to trigger that state change could be done rapidly. In v10, triggering the macro multiple times in a row results in only parts of the targeted tiles changing visibility and the time it takes to change has increased by a factor of at least 10 to 15 (100 ms to 1500 ms).

image

image

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

  1. Create a scene.
  2. Add 6000 or more tiles.
  3. Use a macro to toggle the visibility state of a tile.

What core version are you reporting this for?

Version 10 (build 283)

Relevant log output

const perf = Date.now()
await canvas.tiles.placeables[0].document.update({hidden: !canvas.tiles.placeables[0].document.hidden})
console.log("Compute time:", Date.now()-perf)
VM5172:3 Compute time: 1399
undefined
pixi.min.js:8 [Violation] 'requestAnimationFrame' handler took 213ms
const perf = Date.now()
await canvas.tiles.placeables[0].document.update({hidden: !canvas.tiles.placeables[0].document.hidden})
console.log("Compute time:", Date.now()-perf)
VM5177:3 Compute time: 1343
undefined
pixi.min.js:8 [Violation] 'requestAnimationFrame' handler took 236ms
const perf = Date.now()
await canvas.tiles.placeables[0].document.update({hidden: !canvas.tiles.placeables[0].document.hidden})
console.log("Compute time:", Date.now()-perf)
VM5182:3 Compute time: 1327
undefined
pixi.min.js:8 [Violation] 'requestAnimationFrame' handler took 218ms

Bug Checklist

  • The issue occurs while all Modules are disabled
@Sky-Captain-13 Sky-Captain-13 added the bug Functionality which is not working as intended label Aug 31, 2022
@aaclayton aaclayton added the tiles Issues related to Tiles and their appearance label Aug 31, 2022
@Fyorl Fyorl added this to the V10 - Follow Up milestone Sep 1, 2022
@cswendrowski cswendrowski removed this from the Version 10 - Stable Patch 5 milestone Oct 17, 2022
@Feu-Secret Feu-Secret added this to the Version 11 - Testing 2 milestone May 6, 2023
@Feu-Secret Feu-Secret self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended performance Issues related to application performance optimization tiles Issues related to Tiles and their appearance
Projects
Status: Done
Development

No branches or pull requests

6 participants