Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProseMirror editor saves empty paragraph tags when it has no content #8309

Closed
Fyorl opened this issue Oct 3, 2022 · 1 comment
Closed

ProseMirror editor saves empty paragraph tags when it has no content #8309

Fyorl opened this issue Oct 3, 2022 · 1 comment
Assignees
@Fyorl
Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor
Milestone
Version 10 - Stab...

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Oct 3, 2022

Originally reported by Mana#4176 https://discord.com/channels/170995199584108546/956306859491471420/1026122454051074118

ALL MODULES DISABLED? true
OS, Hosting, Browser (if applicable): any
Short Description of bug: ProseMirror insists on saving at minimum

even if you completely empty the editor even in the HTML view.
Simple steps to reproduce the bug: Write a description. Remove it entirely. Observe the data.
@Fyorl Fyorl added bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor labels Oct 3, 2022
@Fyorl Fyorl added this to the Version 10 - Stable Patch 4 milestone Oct 3, 2022
@Fyorl
Copy link
Contributor Author

Fyorl commented Oct 3, 2022

Marking this as a bug as it is technically a regression from v9 behaviour where empty content would be either "" or null (I forget which), even though this is expected ProseMirror behaviour.

@Fyorl Fyorl assigned Fyorl and unassigned Fyorl Oct 5, 2022
@Fyorl Fyorl self-assigned this Nov 23, 2022
@Fyorl Fyorl closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fyorl Fyorl

Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor
Projects
No open projects
Foundry VTT - Version 10 Maintenance
Status: Done
Milestone
Version 10 - Stable Patch 6
Development

No branches or pull requests
2 participants
@Fyorl @mattexdee