Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing inline journal images to players only displays a blank box #8359

Closed
Fyorl opened this issue Oct 10, 2022 · 5 comments
Closed

Showing inline journal images to players only displays a blank box #8359

Fyorl opened this issue Oct 10, 2022 · 5 comments
Assignees
Labels
bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Oct 10, 2022

Originally reported by PS#9868 https://discord.com/channels/170995199584108546/956306859491471420/1028687867297398788

ALL MODULES DISABLED? true
OS, Hosting, Browser (if applicable): Chrome, Edge, Windows
Short Description of bug: When showing the players only an image that's pasted in a journal (not the whole journal page), they see only a blank window without the image.
Simple steps to reproduce the bug: open any image pasted in a journal page, show it to the players and check if they see anything.
Screenshots and/or console errors:

image

image

@Fyorl Fyorl added bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems labels Oct 10, 2022
@Fyorl Fyorl added this to the Version 10 - Stable Patch 5 milestone Oct 10, 2022
@Fyorl Fyorl self-assigned this Oct 13, 2022
@minnellac
Copy link

minnellac commented Oct 16, 2022

Screen Shot 2022-10-16 at 15 55 48

I'm experiencing this issue in Foundry 10.288 with dnd5e 2.0.3. I've attached a console image from a client that did not receive the images. A client connected to .localhost:30000 gets the images without issue. I was able to reproduce the behavior described above where the full journalsheet renders correctly but the imagepopout does not.

@Fyorl
Copy link
Contributor Author

Fyorl commented Oct 17, 2022

That's a big help, thanks, it's clear where the issue is now.

@Fyorl Fyorl closed this as completed Nov 2, 2022
@minnellac
Copy link

minnellac commented Nov 14, 2022

I saw something that looked like this in the release notes for version 290 with D&D5e; however, when I went to test it I got mixed results. Again, I tested with all modules disabled. This time, I was able to show players some of my journal images, but not others. Here is a screen shot showing an image shown (successfully), and image shown (failed), and another image shown (successfully). The images are all embedded images in a journal (different journals though). Seems like something is still broken.
Screen Shot 2022-11-13 at 21 03 50
This is from the client.

@Fyorl
Copy link
Contributor Author

Fyorl commented Nov 14, 2022

Do you have an excerpt of the <img> element in your journal that is failing to show?

@minnellac
Copy link

I played around with the html and I found that the image displays properly when I use the relative link to the image. Below, the first tag fails and the second one works. I'm not sure why I ended up with a mix in my journals. I was just pasting images in when I created them.

         <img src="http://localhost:30000/worlds/icewind-dale/assets/pages/V1AarXFSO92n2rVi-pages-Sn12kK1IqUSZEw3k-image-1cc8rdr0iTDTwsJ5.png" style="box-sizing: border-box; user-select: text; border: 1px solid var(--color-border-dark); border-radius: 2px; max-width: 100%; cursor: pointer">
         <img src="worlds/icewind-dale/assets/pages/V1AarXFSO92n2rVi-pages-Sn12kK1IqUSZEw3k-image-1cc8rdr0iTDTwsJ5.png" style="box-sizing: border-box; user-select: text; border: 1px solid var(--color-border-dark); border-radius: 2px; max-width: 100%; cursor: pointer">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended journal Issues related to the Journal and Pages systems
Projects
No open projects
Development

No branches or pull requests

2 participants