Fragment output of VisibilityFilter isn't premultiplied

[dev7355608]

What happened?

explored isn't premultiplied, but gl_FragColor needs to be (blendMode is NORMAL). The explored fog is brighter than it should be at the moment.

    float reflec = perceivedBrightness(baseColor.rgb);
    vec4 explored = vec4((exploredColor * reflec) + (baseColor.rgb * exploredColor), 0.5);
    vec4 unexplored = hasFogTexture
                      ? mix(vec4(unexploredColor, 1.0), vec4(fogColor.rgb * backgroundColor, 1.0), fogColor.a)
                      : vec4(unexploredColor, 1.0);

    // Mixing components to produce fog of war
    vec4 fow = mix(unexplored, explored, max(r,v));
    gl_FragColor = mix(fow, vec4(0.0), v);

// FIX:
gl_FragColor.rgb *= gl_FragColor.a;

Also (exploredColor * reflec) + (baseColor.rgb * exploredColor) might yield values larger than 1. Shouldn't there be a min(..., vec3(1.0))?

Another minor issue: canvas.effects.visibility.filter.blendMode is undefined. VisibilityFilter doesn't define a getter for blendMode but a setter; the setter for blendMode doesn't seem to serve any purpose.

What ways of accessing Foundry can you encounter this issue in?

• Native App (Electron)
• Chrome
• Firefox
• Safari
• Other

Reproduction Steps

Good settings to see the difference: Set fog explored and unexplored colors to #ffffff and Darkness Level to 0.5.

What core version are you reporting this for?

Version 10 Stable 4 (build 288)

Relevant log output

No response

Bug Checklist

• The issue occurs while all Modules are disabled