Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover state is temporarily lost when dragging a token within a scene #8579

Closed
3 of 6 tasks
stwlam opened this issue Dec 1, 2022 · 2 comments
Closed
3 of 6 tasks

Hover state is temporarily lost when dragging a token within a scene #8579

stwlam opened this issue Dec 1, 2022 · 2 comments
Assignees
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. tokens Issues related to Tokens and their appearance

Comments

@stwlam
Copy link

stwlam commented Dec 1, 2022

What happened?

If a user drags a token from one location in a scene to another, TokenLayer#hover is set to null despite the dropped token usually being the one that is in fact currently hovered. The hover state isn't then reestablished until a different token is hovered.

This isn't typically a problem in core since the only operation one could perform is targeting, but any other keybind that operates on hovered tokens will also fail.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

  1. Drag a token in a scene and drop it anywhere else.
  2. Attempt to target the token via pressing T.

What core version are you reporting this for?

10.290

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@stwlam stwlam added the bug Functionality which is not working as intended label Dec 1, 2022
@Fyorl Fyorl added tokens Issues related to Tokens and their appearance canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. labels Dec 1, 2022
@Fyorl Fyorl added this to the Version 10 - Leftovers milestone Dec 1, 2022
@stwlam stwlam changed the title Hover state is temporarily lost when dragging a token on a scene Hover state is temporarily lost when dragging a token within a scene Dec 1, 2022
@aaclayton
Copy link
Contributor

I think this issue may be resolved by changes we have already made in V11. Needs verification

@Feu-Secret Feu-Secret self-assigned this Apr 19, 2023
@Feu-Secret
Copy link

@stwlam @aaclayton After some tests and verification, this issue could still happen. Sometimes, when initiating a drag from the edge of a hovered token, a hoverOut could be triggered before a drag operation could occur, this is a very edge case. To counter this edge case, we need to acquire the hovered state as long as the left button is not released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. tokens Issues related to Tokens and their appearance
Projects
Status: Done
Development

No branches or pull requests

4 participants