Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some uses of hard-coded ChatMessage class ignore configured documentClass #8791

Closed
Fyorl opened this issue Jan 23, 2023 · 1 comment
Closed
Assignees
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended chat Issues related to Chat and Chat Messages

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Jan 23, 2023

Originally reported by Cousken#7485 https://discord.com/channels/170995199584108546/956307084931112960/1067085540509368360

I think i found a code bug, unsure how to report it.

tooltip: ChatMessage.metadata.labelPlural,

In sidebar.js, getData function row 65 and onwards.

Hardcoded classes are used for getting tooltips for tabs. If i create a new class that extends ChatMessage with it's own metadata and set it up as a message document class, i expect it to affect the tooltips, which it currently doesn't.

@Fyorl Fyorl added bug Functionality which is not working as intended chat Issues related to Chat and Chat Messages api Issues related to the API used by Mod Devs labels Jan 23, 2023
@Fyorl Fyorl added this to the Version 10 - Leftovers milestone Jan 23, 2023
@Fyorl Fyorl self-assigned this Apr 20, 2023
@Fyorl Fyorl closed this as completed Apr 21, 2023
@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 21, 2023

We have fixed some instances where ChatMessage.create was being used instead of ChatMessage.implementation.create, however, in regards to the issue reported in the body, replacing any Document metadata is not supported. For changing labels, the system should override the localisation key rather than attempting to change metadata.labelPlural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended chat Issues related to Chat and Chat Messages
Projects
Status: Done
Development

No branches or pull requests

1 participant