Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults of the blindness vision mode are not applied if the vision source is blinded #8928

Closed
1 of 6 tasks
dev7355608 opened this issue Feb 24, 2023 · 0 comments
Closed
1 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes

Comments

@dev7355608
Copy link

What happened?

The attenuation/contrast/saturation/brightness of a blinded vision source should be overridden by the defaults of blindness mode and the vision color should be set to null, right?

{ attenuation: 0, contrast: -0.5, saturation: -1, brightness: -1 }
    // Handle the blinded special status
    if ( this.data.blinded ) {
      this.visionMode = CONFIG.Canvas.visionModes.blindness;
      this.data.radius = this.data.externalRadius;
+     this.data.color = null;
+     foundry.utils.mergeObject(this.data, this.visionMode.vision.defaults);
      return;
    }

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Place a token with vision and blind the token. Change any of the Advanced Vision Options.

What core version are you reporting this for?

Version 10 Stable 6 (build 291) / Version 11 Prototype 1 (build 292)

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Feb 24, 2023
@aaclayton aaclayton added the vision Issues related to Token vision and vision modes label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes
Projects
Status: Done
Development

No branches or pull requests

3 participants