Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the activation of the detection filter on the token mesh. #9024

Closed
1 of 6 tasks
dev7355608 opened this issue Mar 7, 2023 · 0 comments
Closed
1 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes

Comments

@dev7355608
Copy link

What happened?

I suggest to add the detection filter temporarily in Token#render instead of adding the detection filter to the mesh's filters in the detectionFilter setter. This ensures that the detection filter is applied last. There isn't a chance that a module that adds filters to the token's mesh changes this order or even removes the detection filter accidently.

  /**
   * The filter to use for detection.
   * @type {PIXI.Filter|null} filter
   */
  detectionFilter = null; // no need for a setter

  /** @override */
  render(renderer) {
    if ( this.#detectionFilter ) {
      this.mesh.filters ??= [];
      this.mesh.filters.push(this.#detectionFilter);
      /* render... */
      this.mesh.filters.pop();
    }
    super.render(renderer);
  }

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

.

What core version are you reporting this for?

Version 11 Prototype 2 (build 293)

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Mar 7, 2023
@aaclayton aaclayton added the vision Issues related to Token vision and vision modes label Mar 7, 2023
@Feu-Secret Feu-Secret self-assigned this Mar 7, 2023
@Feu-Secret Feu-Secret changed the title Token#detectionFilter doesn't have a getter Simplify the activation of the detection filter on the token mesh. Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes
Projects
Status: Done
Development

No branches or pull requests

3 participants